PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Destrutive Link Gives incorrect Critical strike chance
Nadie ha tomado este issue todavía.
- Lenguaje dominante
- Lua
- Estrellas
- 5.4k
- Forks
- 2.4k
- Merge medio
- 1 d 12 h
- PR fusionados (30 d)
- 26
Descripción
Check version
- I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
- I've checked for duplicate issues by using the search function of the issue tracker
Check for support
- I've checked that the behaviour is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What is the behaviour in-game?
Destructive Link gives the players final critical strike chance of a basic attack with the mainhand weapon after modifiers to the linked target
What is the behaviour in Path of Building?
Only gives the mainhand weapons base critical strike chance, and does not take into account other modifiers like power charges or crit from tree
Additional Info
#6139 added support for destructive links critical strike chance mod but does not properly give correct crit chance, this is fine for how most people use it (with Trypanon) but can be misleading, it wasnt properly support due to not having the calculated crit chance, as this would require an extra calc pass (like fulldps) of a basic attack to get the correct value taking into account buffs etc
This is relatively low priority to fix though due to Trypanon being the main use of the link
How to reproduce the issue
No response
Character build code
No response
Screenshots
No response
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Línea de trabajo
Revisa primero el issue #6139 y el manejo existente de los golpes críticos de Destructive Link. Traza cómo el cálculo del ataque básico obtiene actualmente la probabilidad base del arma de la mano principal y, después, determina cómo un pase de cálculo podría incluir power charges, modificadores del árbol pasivo y otros buffs; se considera terminado cuando coincida con la probabilidad final de golpe crítico del objetivo enlazado.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- lua
- Área
- backend
- Tipo de issue
- Error
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Estado de actividad
- Estancado
- Claridad
- Bastante claro
- Aptitud para principiantes
- 38/100