PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Destrutive Link Gives incorrect Critical strike chance
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 5.4k
- Forks
- 2.4k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 26
Description
Check version
- I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
- I've checked for duplicate issues by using the search function of the issue tracker
Check for support
- I've checked that the behaviour is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What is the behaviour in-game?
Destructive Link gives the players final critical strike chance of a basic attack with the mainhand weapon after modifiers to the linked target
What is the behaviour in Path of Building?
Only gives the mainhand weapons base critical strike chance, and does not take into account other modifiers like power charges or crit from tree
Additional Info
#6139 added support for destructive links critical strike chance mod but does not properly give correct crit chance, this is fine for how most people use it (with Trypanon) but can be misleading, it wasnt properly support due to not having the calculated crit chance, as this would require an extra calc pass (like fulldps) of a basic attack to get the correct value taking into account buffs etc
This is relatively low priority to fix though due to Trypanon being the main use of the link
How to reproduce the issue
No response
Character build code
No response
Screenshots
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review issue #6139 and the existing Destructive Link critical-strike handling first. Trace how the basic attack calculation currently obtains the mainhand weapon's base chance, then determine how a calculation pass could include power charges, passive-tree modifiers, and other buffs; done means matching the linked target's final critical strike chance.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100