PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Explosive Concoction Flask Data

未关闭
#6,552 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

enhancement
主要语言
Lua
星标
5.4k
派生
2.4k
平均合并
1 天 12 小时
30 天内合并 PR
26

描述

Check for duplicates
  • I've checked for duplicate issues by using the search function of the issue tracker
Is your feature request related to a problem?

The program contains a lot of detailed information regard Explosive Concoction and its specialness. However there are a couple of details that are either not calculate or not displayed. Specifically, the skill's flask charge consumption.

This comes with two other statistics not displayed that, I think, would be helpful overall:

  • +% Total Charges Recovered
    • Base
    • With buffs (ex. Overflowing Chalice)

If possible, a per flask calculation would be absolutely amazing. Enkindling Orb 62% increased recover with the "Rationed" prefix 64% plus a bunch other stuffs in the Explosive Concoction build I am using will replenish ~5 flask charges on a critical hit. And also:

  • Charge on crit % chance
    Ok, this is actually in PoB, but it does not seem to display any chances outside of the Flask Mastery bonus for crit charge (Precursor's Emblem or an active Rotgut, for example).
Describe the solution you'd like

When previewing the Calculations section, under a relevant sub-category:

  • the amount of charges that the skill Explosive Concoction consumes from equipped flasks should be a displayed stat
  • the calculated actual value of the number of charges regained
    • allow for calculating using other (temporary) increase buffs
  • a data table containing the calculated actual value of equipped flask charges regained
Describe alternatives you've considered

There are no alternatives. Just cold, hard, pen and paper mathematics.

Additional context

I have no recorded data... yet! Now that I know of this request, I will document and (hopefully) update this with all that ye need.

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

调研方向

首先定位 Explosive Concoction 的计算,以及显示 skill 统计信息的 Calculations 部分。检查 flask charges、temporary buffs 和 charge-on-critical effects 的表示方式。完成的标准是显示 issue 要求的 consumption value、recovered-charge calculations、per-flask table 以及相关的 critical-charge chance,但 issue 没有提供可作为目标的文件或测试。

由索引模型根据 Issue 内容生成。

评估

技术栈
lua
领域
game-dev
Issue 类型
功能
难度
5/5
预计耗时
一周以上
活跃度
停滞
描述清晰度
需要澄清
新手友好度
25/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。