PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Explosive Concoction Flask Data

Open
#6,552 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check for duplicates
  • I've checked for duplicate issues by using the search function of the issue tracker
Is your feature request related to a problem?

The program contains a lot of detailed information regard Explosive Concoction and its specialness. However there are a couple of details that are either not calculate or not displayed. Specifically, the skill's flask charge consumption.

This comes with two other statistics not displayed that, I think, would be helpful overall:

  • +% Total Charges Recovered
    • Base
    • With buffs (ex. Overflowing Chalice)

If possible, a per flask calculation would be absolutely amazing. Enkindling Orb 62% increased recover with the "Rationed" prefix 64% plus a bunch other stuffs in the Explosive Concoction build I am using will replenish ~5 flask charges on a critical hit. And also:

  • Charge on crit % chance
    Ok, this is actually in PoB, but it does not seem to display any chances outside of the Flask Mastery bonus for crit charge (Precursor's Emblem or an active Rotgut, for example).
Describe the solution you'd like

When previewing the Calculations section, under a relevant sub-category:

  • the amount of charges that the skill Explosive Concoction consumes from equipped flasks should be a displayed stat
  • the calculated actual value of the number of charges regained
    • allow for calculating using other (temporary) increase buffs
  • a data table containing the calculated actual value of equipped flask charges regained
Describe alternatives you've considered

There are no alternatives. Just cold, hard, pen and paper mathematics.

Additional context

I have no recorded data... yet! Now that I know of this request, I will document and (hopefully) update this with all that ye need.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the Explosive Concoction calculations and the Calculations section that displays skill statistics. Review how flask charges, temporary buffs, and charge-on-critical effects are represented. Done means the issue's requested consumption value, recovered-charge calculations, per-flask table, and relevant critical-charge chance are displayed, but the issue provides no files or tests to target.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
game-dev
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.