PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Flask uptime calculation with Mod "Used when Charges reach full"
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 5.4k
- Forks
- 2.4k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 26
Description
The calculation of the flask uptime seems wrong in the tooltip of the flask item.
The tool shows 100% flask uptime like this
But in reality the charges of the flask does not reach full before the end of the effect so there is a slight delay before the next trigger of the flasks.
I am not really sure as of why but if I allocate the last node in the "Natural Remedies" wheel, the uptime is now 100% in game
PoB to reproduce https://pobb.in/gGJdoLC-vZ9s
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the flask uptime tooltip with the linked PoB at https://pobb.in/gGJdoLC-vZ9s, then trace the calculation that reports 100% uptime for "Used when Charges reach full." Compare it with the in-game delay before the next trigger and with the result after allocating the final Natural Remedies node. Done means the tooltip reflects the observed charge recovery timing.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- game-dev
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100