PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

'Master Set' to aid in gear change and build comparison

Abierto
#5,633 1 comentario 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

enhancement
Lenguaje dominante
Lua
Estrellas
5.4k
Forks
2.4k
Merge medio
1 d 12 h
PR fusionados (30 d)
26

Descripción

Check for duplicates
  • I've checked for duplicate issues by using the search function of the issue tracker
Is your feature request related to a problem?

When making multi-faceted gear changes, it is difficult to isolate the updates, and compare to the original state.

Example:
If I'm adding the capacity to gain Frenzy Charges, I need to not only change gear, but also add the check box for "Do you use Frenzy Charges?"
When checking to see how this affects my damage, I need to compare DPS while wearing the new gear that adds this capacity (equipment set), and then check the box for Frenzy Charges. (See issue #4874 for the custom modifiers on the configuration tab - this request is for the whole tab, and more.)

Describe the solution you'd like

IT would be easier to compare upgrades that span multiple sets or non-set related items if there were:
sets for Configuration settings,
and a "Master Set" that combines multiple sets into one easy to swap to configuration.

In the example above, I could create a new gear set (exists), a new configuration set (does not exist), and a "Master Set" that automatically switches to a defined set of each type. Ideally, this would allow for mouseover stat differences, or a side by side comparison of the stat window (left hand side skill/hp/resist preview).

Currently existing sets:
Gear
Skills
Atlas Passives

Needed Sets:
Configuration
"Master Set"

Describe alternatives you've considered

Currently, I can either open two instances of the program with the same save file (sketchy, and prone to odd behaviors), or save my build, take screenshots, then adjust settings. Both of these options are clunky and less than optimal. When working with a single monitor, this is even more difficult.

As an alternative programmatic solution, I would suggest the capacity for adding a "freeze frame" of the left side stat window, so that the original state can be viewed and compared side by side. A further enhancement would be an option to highlight changed stats, such as +55 (+1%) Life.

Additional context

Example of Master Set Configuration:
Master Set Configuration

Example of Build Comparison
PoB Build Comparison Example

Guía de contribución

Abrir la guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Línea de trabajo

En el issue no se identifican archivos, pruebas ni puntos de entrada. Empieza por localizar las implementaciones existentes de los sets Gear, Skills y Atlas Passives, así como la pestaña de configuración. La tarea estaría terminada cuando exista un flujo funcional de Configuration set y Master Set, y el comportamiento solicitado para la comparación de builds esté definido y cubierto por las pruebas adecuadas.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
lua
Área
desktop-dev
Tipo de issue
Nueva funcionalidad
Dificultad
5/5
Tiempo estimado
Más de una semana
Estado de actividad
Estancado
Claridad
Bastante claro
Aptitud para principiantes
25/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.