PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

'Master Set' to aid in gear change and build comparison

Open
#5,633 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check for duplicates
  • I've checked for duplicate issues by using the search function of the issue tracker
Is your feature request related to a problem?

When making multi-faceted gear changes, it is difficult to isolate the updates, and compare to the original state.

Example:
If I'm adding the capacity to gain Frenzy Charges, I need to not only change gear, but also add the check box for "Do you use Frenzy Charges?"
When checking to see how this affects my damage, I need to compare DPS while wearing the new gear that adds this capacity (equipment set), and then check the box for Frenzy Charges. (See issue #4874 for the custom modifiers on the configuration tab - this request is for the whole tab, and more.)

Describe the solution you'd like

IT would be easier to compare upgrades that span multiple sets or non-set related items if there were:
sets for Configuration settings,
and a "Master Set" that combines multiple sets into one easy to swap to configuration.

In the example above, I could create a new gear set (exists), a new configuration set (does not exist), and a "Master Set" that automatically switches to a defined set of each type. Ideally, this would allow for mouseover stat differences, or a side by side comparison of the stat window (left hand side skill/hp/resist preview).

Currently existing sets:
Gear
Skills
Atlas Passives

Needed Sets:
Configuration
"Master Set"

Describe alternatives you've considered

Currently, I can either open two instances of the program with the same save file (sketchy, and prone to odd behaviors), or save my build, take screenshots, then adjust settings. Both of these options are clunky and less than optimal. When working with a single monitor, this is even more difficult.

As an alternative programmatic solution, I would suggest the capacity for adding a "freeze frame" of the left side stat window, so that the original state can be viewed and compared side by side. A further enhancement would be an option to highlight changed stats, such as +55 (+1%) Life.

Additional context

Example of Master Set Configuration:
Master Set Configuration

Example of Build Comparison
PoB Build Comparison Example

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files, tests, or entry points are identified in the issue. Start by locating the existing Gear, Skills, and Atlas Passives set implementations and the configuration tab. Done would require a workable Configuration set and Master Set flow, with the requested build comparison behavior defined and covered by appropriate tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
desktop-dev
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.