PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Exerted attack damage modifiers double dip with General's Cry + another warcry

Aperta
#5,220 2 commenti 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

bug
Lingua principale
Lua
Stelle
5.4k
Fork
2.4k
Merge medio
1g 12h
PR unite (30g)
26

Descrizione

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate issues by using the search function of the issue tracker
What is the expected behaviour/value?

Berserker's War Bringer should apply a <=50% more damage multiplier, depending on the calculated uptime.

What is the actual behaviour/value?

The damage multiplier of War Bringer is applied twice to attacks supported by General's Cry if there's another active warcry in the skill list (applies both the uptime scaled damage multiplier and a static 50% more).

How to reproduce the issue
  1. Select marauder / berserker, allocate War Bringer
  2. Add General's Cry linked to Tectonic Slam
  3. Add Infernal Cry
Character build code
eNqtW1t34jgSfu75FRwe9qkTMLckszBzCJCEc0LCBrp796mPsAV4IkuMJSdhfv2WJBscgoysdD-kDarrp1KpSjLdP98iUnnBMQ8Z7VW983q1gqnPgpCuetVv85uzy-qff_zWnSKxflxeJyGRI3_89qWrnisEv2ACfHXgEyheYfE9k9X8Cd9tEBVrzOgE_cXiWxb0qg-M4mplgWgQiuyTTxDnDyjCveoExSgJcFytIO5jGgz2Q9cgGcfPcixCIZ0x_xmL25glGzCgWnkJ8euEBUA4nkwfn-Y55SHNKwfrv3SnBG1xPBNIVDj86VX7AAJa4SGK4C9IQyQBUc3zi8ZVp1o7zjPbYBzsaD0T2TTGo-US-yJ8wYM4FIM1ov5eR93EV5Z2khARbkgoEcpsOm-bOO4-CG9cmmjnTCAynM52pO1zr3nhXdXrl41Oq9Up5mPitP0_QrG-JgCngxbJO17RUGBH5ikLOaOf8C_Pap6ihBBYPHa0LFqE1AmNfozR41IH3BMKwoTvo8EYDBNE0YDx_UR5RtPuwyV-R2qkHM3s6J5gxdlRSjOnOIbEIOwYpLGlGFINM-wzSD5ldJRhyfnhpsyBczRzYXBQNBP7_NNsGCcd_50n9NrG2Bzitz1Zy0Q1psKCaohfmIDt6bQXammP7qZ7oY0ro9jpestDH5EJegujJILUOkfPmOZ42y3zjK7WgkJiMDFfXMIuZETnJoyxG-eAkcCRc40Yd2OV8WsFC-yt_u-Sekx9u2XxjcYYCoSX_JZciPsSP0FYy31_QbA1z15NujxyObNerGyFaapxa-fSPcb--haKnScksF1a2VF1Wl4htpLYCltJeATbAvnvOUrAJBmPw-R5540irpJI_UBxYJEBKY5X29k6xKQkdWb_AG0sEqacjjy31bS8V1cqtPKsJYEbvSCez5_mkkJ7pcnt4gxD_QcMAbYteqcx-0uW1aQcWz-OWBJbzosmtnIg2wV0D_GEg8S322uuCfQyttaDVYSU4ugLgfznIQtWuJSS8hyzZLOBZS-n3JZP7l9PmIe5yuKsY0H9CKFutbrkNmevYE9trWC3gdtrOWCx90VuvCWc2ZNbq9h1qhNIJhHkbdXkQmN9us-9gQbHqrtRhJZd05S9guVrebbAy1FDgbKvQ42mxJj-s7WW_47cSsGIBkksl4K1jkOOY2rmYQTZkvMhEqjCMYr99T3Mcq9azX26QYQsYOXDt5KrW1NnNvJpHG1YLNSXA0R8rmSO6SYRFarOWqKQ-z8XyXIpT1RApojVgdDo5mY0mI-_j1Iz8iz8OSTkJ02ihTx_0P_vg2WGVS6s8GTB9WOv-j3ErzPJNcQChQSg8RkhaMNx0KsuEeGgOYRHRTMDf31RIE1RQTWaneAcl7UnMEsaveFYgL9QJPhxiI127cZPGKUVyr1ZTptJmjwmMQvSOXyAuND7tAEpdSBlliJPiYzuyMECXogZRIya09ETSIjtBnPYVcNl6MuIL57yOVBrqgJcfB8Wi78tmO90JzLLUOdOJgF60Mysz45M3OloAarq3MqIqh41sw-xj4y-60Ez8670YxRgMknZURVIemBUBTksmn5I5K5hnNkRwTsSs8BHscax3oqMkiaQozKSwoUTh4tEmJdxjqIAK9W3GhCSY2ZW3ZUZfJBjBZnoXQNiADRPYxalOx5jIitizeplA3x6tMCJrGUw2J8OmwXoCsY4f2k9VLS-oVg2r285aGbW6-OjCBEnlhJULA_xEkMWKgzmHU1BFhUJHULCEwWAWorSu1L_hYWBrtQ_JU05eVzYHqlSsnSSOIpbaYmqk_ks9AcNzi-BPz06M-TvHMkJQZB47wq2djtJu9L_DiMib0UY-ZzAD0eEn_KTCY5oMJRHHdaOdmtZfdtVJQWvcCh8b3HEr7fQftzIpHlw2xIhAfsdju7l1eacySIc-QLH9_qqM1WGFFBpZSrUBeQ7yVmQBniJEiK__0-CSCi2vWqjmf86FUtDwJqv2auMMC1Ilj8c8uv9vR7pE5HKkFoySzReqR0KA099l36prkr7e2MVHGADwEV9kgR4TNO2LbWBoIW0R14Dy2PR3Wo7kCNFKDVfumBNSnxL2AKRRsaSXg436tV34142rjqGMWi4xbCHgTcDeXj1t_ZxrAoYhVK1ssKR_DyBPiGAjqc2FoBATcJQU9bA0zEZGusDR3yWUD1hsm-RZzw7A_6FNoz_m1ekjNov8-6gn5sRFDl7OYfVwCgUz3kh1m5m3BXFrj3satmnQ0ZFx2eDRlL_MmD7iy3niBijRhFOUaxhsED3iEBrbMd0iWOKSC54ctCmj7BEVVLSuUg-zmOMs2Si5HjpioYP-VcgpOkNCSiHVLRNy16JOIUGXS7oq8ZV62u7Xm-0vrYuvIv212aj0QYLBSjIvZPhXaWvW4xzmeLb072elLUQG_57rfb6-nq-QWLNlvgtJPjcZ1FtA0xg5ZlC9UyKrfXh3_VqNOjzB7ZccvjU62nHM4ld_ZYGr6UggFcKAOm2fHhgUHbLMfll9kGBIg8H0rOMmYilp_8wFv2vVz1rdDrnjYuOToqwVYkJ2qRxKEnShJqOy_5xGAJcsdqQsxmUhP8FIu_yvJPeUXZVQKRzIZ-zvJ5wrK8_f2DID1R9ncVxNyU0Er3PyIRlpyWarOLNXtGmksZdRYNVaQOX0NFaz0LpCOshW8OOrZjqmsE262jQMV9OGHWNiSjJcgPR-1xpWpnUOGZS0w1eOxAav4it5WZkx01bxx1Nl3g6MQN3GEp_UVbRkUjquOg5EX6wGb3IdqS84Kb7KvJc9LXcYsFzi7zW6emxAbas2GPh5ei4Vd5pO9jjkAObp9QE24o-eCk5fcdRdoqvtguT1ZK0mQgnP9vOsDYc5r3jtpKabuHbLB9lLfe07xDTnjP4TZuAaNkQOZj9ieLHcibdZ6HjEJXu0_CJcLFNyZLXctXYkzog9xTSlV0lUDpRGOF1TBf28-niTtMCJ899GlrOaLVdvLFZL-5BfsKkfpSQI3tbt5b2kKoxVk2oupdndBmuPtyyH_6mYX83r37b8PFaHlMcbcf8mnF-kvbw1xonGfTPOI6STQny8ZqRAMd5S9KfTGSvB1zk3wU8Ri8vpbMb_YypacGTvX6U8bSLWd6_upV7fSF76bdbyyakWzv8Mcz_AdiUXtA=
Screenshots

image

Guida per i contributori

Apri la guida per i contributori

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Direzione di ricerca

Riproduci il problema con un Berserker usando War Bringer, General's Cry collegato a Tectonic Slam e Infernal Cry, utilizzando il codice della build fornito se necessario. Traccia il calcolo dei danni per gli attacchi di General's Cry e confrontalo con il valore atteso di War Bringer scalato in base al tempo di attività; il lavoro è completo quando il modificatore viene applicato una sola volta.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
lua
Ambito
backend
Tipo di issue
Bug
Difficoltà
3/5
Tempo stimato
1-2 giorni
Stato di attività
Ferma
Chiarezza
Abbastanza chiara
Idoneità per principianti
45/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.