PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Allow Toggle to shut off 'Have you attacked recently' and 'Have you cast a spell recently' when primary skill is tagged Attack/Spell

Aperta
#5,153 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

bug: behaviour
Lingua principale
Lua
Stelle
5.4k
Fork
2.4k
Merge medio
1g 12h
PR unite (30g)
26

Descrizione

Check for duplicates
  • I've checked for duplicate issues by using the search function of the issue tracker
Is your feature request related to a problem?

The current implementation of 'Have you attacked Recently' and 'Have you cast a spell recently' checkboxes assumes true if the primary skill gem has the Attack or Spell tag respectively.

I'm running a holy relic guardian. My main skill is 'Summon Holy Relic'. This is the skill I normally want to see the DPS/stats from in PoB. This gem has the 'Spell' tag, so PoB is using this to assert that I've cast a spell recently.

I've taken the ascendency node Bastion of Hope, which states 'If you've cast a spell recently, you and nearby allies have 10% chance to block spell damage'.

However, holy relics are semi-permanent.... the only time I cast them is when they die, which is rare. I use cyclone to trigger the holy relics, so I'm channeling, but rarely actually casting a spell. So most of the time, 'Have you cast a spell recently' is false, I have not. In-game I will not usually have this extra spell block chance.

You can switch the skill to a different one in PoB (i.e. an attack skill, cyclone) to see the right spell block values, but that's really a workaround.

Also, switching to cyclone adds regular block chance, since bastion of hope also states 'If you've attacked recently, you and nearby allies have 10% chance to block attack damage'. But this is also often false. This is only triggered when you 'attack', which appears to only be true with cyclone when you initially engage the skill. As you channel cyclone, this buff falls off, regardless of whether you're hitting enemies. (tested in-game while observing the tooltip window).

If you're mostly spinning-to-win and just holding cyclone on, you won't be considered to have attacked recently most of the time either.

Describe the solution you'd like

It would be nice if we could forcibly disable the 'Have you attacked recently' and 'Have you cast a spell recently' checkboxes when they're assumed to be enabled due to the gem tags. The current implementation is misleading for builds that use minion (spell) skills and channeling attack skills like cyclone.

Describe alternatives you've considered

Switching the skill to a non-attack or non-spell skill shows the correct values, but it means I have to switch skills each time I mess with the tree/gear setups in order to see accurate block/spell block chances.

Additional context

No response

Guida per i contributori

Apri la guida per i contributori

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Direzione di ricerca

La issue non indica file, test o punti di ingresso. Inizia individuando i controlli 'Have you attacked recently' e 'Have you cast a spell recently' e la logica che deduce i relativi valori dai tag delle abilità primarie. Il lavoro è completato quando gli utenti possono disabilitare esplicitamente questi stati dedotti, mantenendo calcoli accurati di blocco e blocco degli incantesimi.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
lua
Ambito
game-dev
Tipo di issue
Funzionalità
Difficoltà
4/5
Tempo stimato
3-5 giorni
Stato di attività
Ferma
Chiarezza
Abbastanza chiara
Idoneità per principianti
35/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.