PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Allow Toggle to shut off 'Have you attacked recently' and 'Have you cast a spell recently' when primary skill is tagged Attack/Spell

Abierto
#5,153 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

bug: behaviour
Lenguaje dominante
Lua
Estrellas
5.4k
Forks
2.4k
Merge medio
1 d 12 h
PR fusionados (30 d)
26

Descripción

Check for duplicates
  • I've checked for duplicate issues by using the search function of the issue tracker
Is your feature request related to a problem?

The current implementation of 'Have you attacked Recently' and 'Have you cast a spell recently' checkboxes assumes true if the primary skill gem has the Attack or Spell tag respectively.

I'm running a holy relic guardian. My main skill is 'Summon Holy Relic'. This is the skill I normally want to see the DPS/stats from in PoB. This gem has the 'Spell' tag, so PoB is using this to assert that I've cast a spell recently.

I've taken the ascendency node Bastion of Hope, which states 'If you've cast a spell recently, you and nearby allies have 10% chance to block spell damage'.

However, holy relics are semi-permanent.... the only time I cast them is when they die, which is rare. I use cyclone to trigger the holy relics, so I'm channeling, but rarely actually casting a spell. So most of the time, 'Have you cast a spell recently' is false, I have not. In-game I will not usually have this extra spell block chance.

You can switch the skill to a different one in PoB (i.e. an attack skill, cyclone) to see the right spell block values, but that's really a workaround.

Also, switching to cyclone adds regular block chance, since bastion of hope also states 'If you've attacked recently, you and nearby allies have 10% chance to block attack damage'. But this is also often false. This is only triggered when you 'attack', which appears to only be true with cyclone when you initially engage the skill. As you channel cyclone, this buff falls off, regardless of whether you're hitting enemies. (tested in-game while observing the tooltip window).

If you're mostly spinning-to-win and just holding cyclone on, you won't be considered to have attacked recently most of the time either.

Describe the solution you'd like

It would be nice if we could forcibly disable the 'Have you attacked recently' and 'Have you cast a spell recently' checkboxes when they're assumed to be enabled due to the gem tags. The current implementation is misleading for builds that use minion (spell) skills and channeling attack skills like cyclone.

Describe alternatives you've considered

Switching the skill to a non-attack or non-spell skill shows the correct values, but it means I have to switch skills each time I mess with the tree/gear setups in order to see accurate block/spell block chances.

Additional context

No response

Guía de contribución

Abrir la guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Línea de trabajo

El issue no menciona archivos, pruebas ni puntos de entrada. Empieza localizando los controles 'Have you attacked recently' y 'Have you cast a spell recently', así como la lógica que infiere sus valores a partir de etiquetas de habilidades principales. Se considera terminado cuando los usuarios pueden desactivar explícitamente esos estados inferidos y se mantienen los cálculos precisos de bloqueo y bloqueo de hechizos.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
lua
Área
game-dev
Tipo de issue
Nueva funcionalidad
Dificultad
4/5
Tiempo estimado
3-5 días
Estado de actividad
Estancado
Claridad
Bastante claro
Aptitud para principiantes
35/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.