PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Rattling Bellow double damage mod is blue but has no effect

未关闭
#3,797 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

bug
主要语言
Lua
星标
5.4k
派生
2.4k
平均合并
1 天 12 小时
30 天内合并 PR
26

描述

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate issues by using the search function of the issue tracker
What is the expected behaviour/value?

The Rattling Bellow notable modifier "Exerted Attacks have 8% chance to deal Double Damage" should have some impact on DPS for buildings that use warcries that exert attacks

What is the actual behaviour/value?

The "Exerted Attacks have 8% chance to deal Double Damage" mod is blue but has no impact on DPS.
The mod does get parsed to "ExertDoubleDamageChance" but then we don't ever do anything with it in CalcOffence

How to reproduce the issue

Equip melee attack, any offensive warcry, and a Megalomaniac with Rattling Bellow
Optional: Equip Brass Dome so strength doesn't impact damage
Allocate Rattling Bellow and notice that nothing changes despite you having exerted attacks and the mod being blue

Build code
https://pastebin.com/hF2dt1Qd
Screenshots

No response

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

调研方向

从 CalcOffence 开始,目前其中解析出的 ExertDoubleDamageChance 修正器尚未被使用。使用链接的 build code,通过一次近战攻击、一个攻击性 warcry 和 Rattling Bellow 重现该问题,然后验证 exerted-attack DPS 是否反映了造成双倍伤害的 8% 概率。

由索引模型根据 Issue 内容生成。

评估

技术栈
lua
领域
game-dev
Issue 类型
缺陷
难度
3/5
预计耗时
1-2 天
活跃度
冷清
描述清晰度
基本清楚
新手友好度
68/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。