PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Rattling Bellow double damage mod is blue but has no effect

Open
#3,797 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate issues by using the search function of the issue tracker
What is the expected behaviour/value?

The Rattling Bellow notable modifier "Exerted Attacks have 8% chance to deal Double Damage" should have some impact on DPS for buildings that use warcries that exert attacks

What is the actual behaviour/value?

The "Exerted Attacks have 8% chance to deal Double Damage" mod is blue but has no impact on DPS.
The mod does get parsed to "ExertDoubleDamageChance" but then we don't ever do anything with it in CalcOffence

How to reproduce the issue

Equip melee attack, any offensive warcry, and a Megalomaniac with Rattling Bellow
Optional: Equip Brass Dome so strength doesn't impact damage
Allocate Rattling Bellow and notice that nothing changes despite you having exerted attacks and the mod being blue

Build code
https://pastebin.com/hF2dt1Qd
Screenshots

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in CalcOffence, where the parsed ExertDoubleDamageChance modifier is currently not used. Reproduce the issue with a melee attack, an offensive warcry, and Rattling Bellow using the linked build code, then verify that exerted-attack DPS reflects the 8% chance to deal double damage.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
game-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.