PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Configurable exerted attack uptime for warcries
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 5.4k
- Forks
- 2.4k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 26
Description
Check for duplicates
- I've checked for duplicate issues by using the search function of the issue tracker
Is your feature request related to a problem?
I am using warcries to exert Rage Vortex, which has a duration of 3 seconds, and so I can easily keep 100% uptime on my warcry exerts. However the program seems to be assuming that I am spamming rage vortex at the minimum attack interval in its calculations, which is indicating only 7% uptime.
Describe the solution you'd like
I want to be able to force 100% uptime for exerted attacks in the calculations,
Describe alternatives you've considered
The "Max Hit" setting for warcries in the configuration was suggested by a reddit user, but that is either bugged or does not do what I want it to do, as enabling it actually drops my DPS from 450k to 110k.
Additional context
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the issue with a warcry, Rage Vortex, and the current configuration settings, then trace the exerted-attack uptime calculation. Compare the existing "Max Hit" setting with the requested configurable uptime behavior. Done means the calculations can represent sustained exert uptime without reducing the reported DPS unexpectedly.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- game-dev
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100