PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Incorrect DPS calculation with Anomalous Mirage Archer + Barrage (+ support)

Open
#3,145 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate issues by using the search function of the issue tracker
What is the expected behaviour/value?

Anomalous Mirage Archer grants two extra projectiles, which should significantly affect the output displayed DPS on skills that heavily rely on arrow count (e.g. Barrage and Barrage Support).

The correct behavior should be a visible DPS increase over the standard quality.

What is the actual behaviour/value?

As of the current version, even though the Anomalous quality seems to be coded in and supposedly counts the two extra projectiles (1 per 10% quality on the support gem), the DPS calculation actually shows a drop in DPS; the skill loses the standard increased damage quality and ignores the bonus projectiles.

How to reproduce the issue

It's as simple as linking a Barrage or Barrage Support + main skill e.g. Lightning Arrow to Anomalous Mirage Archer.

Build code
Not required as it's not build-dependent.
Screenshots

image
image

(note the selected quality types and drop in DPS)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source files or tests are named. Reproduce the Barrage or Barrage Support case with Anomalous Mirage Archer and compare it with standard quality, then trace the projectile and quality handling in the DPS calculation. Done means the anomalous quality accounts for its extra projectiles and produces the expected DPS increase without losing the standard quality behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.