PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Animated Guardian's Gear does not affect dps of other minions or player

Open
#2,470 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Running Version 2.0.3

  • What happened?
    When Animated Guardian (AG) is equipped with Support Gear like Dying Breath, Leer Cast or something else the regarding buffs don't scale up the calculated total dps of the player or other minions

  • What were you trying to do?
    I put in another Item set and set it as default item set for the Animated Guardian. Then I expected the total DPS of Raise Spectre to rise. At least to differ from before. Nothing happened.

  • What steps will reproduce the bug?

  1. Add a Skill "Animated Guardian" to Skills
  2. Add a Skill "Raise Spectre" to Skills
  3. Switch to "Items" and Manage Item Sets.
  4. Create a New Set with e.g. "Dying Breath" and "Leer Cast"
  5. Save under a different name
  6. Switch to Skills and Select "Animated Guardian", change 'Default Item Set' to save one from step before
  7. Switch to Raise Spectre and Default Item Set in Main Window -> Calculated total damage is expected to rise by roughly 30% from both items, but calculation does not seem to notice

DPS of Spectre with default (Empty) Item Set of AG
image

DPS of Spectre with Item Set as Shown above
image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue with the provided build code by configuring Animated Guardian with Dying Breath and Leer Cast, then compare Raise Spectre's calculated damage with and without that item set. Trace the Animated Guardian skill's default item-set selection and the calculation path that applies its support-gear buffs; done means the dependent player or minion DPS changes as expected.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.