PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

"# of Poison on Enemy" doesn't affect DPS

Open
#1,085 4 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

  • What happened?

Setting the "# of Poison on Enemy" field in "For Effective DPS" doesn't change the Combined DPS of a skill that applies poison; PoB continues to figure combined DPS as if maximum stacks were applied.

  • What were you trying to do?

I had a feeling my not-very-good Toxic Rain build wasn't doing the damage PoB suggested it was. Digging into the Calcs tab, I figured out that it was supposing I had the maximum of ~23 poison stacks applied, which is a really unlikely scenario. I tried reducing the # of Poison on Enemy to get a more realistic idea of the combined DPS, but it didn't change anything.

  • What steps will reproduce the bug?
  1. Create new build
  2. Add a skill that would work with the Poison support, the Poison support, and a weapon that works with the skill
  3. Check Max Poison Stacks on Calcs tab (I did Split Arrow and +3 thicket bow, it says 2)
  4. On Configuration tab, set # of Poison on Enemy below that maximum

DPS does not change.

  • Does it reproduce every time? If not, why so?

Yes

  • Additional information:

https://pastebin.com/HQHiHrQs - the trash Toxic Arrow build showing 286k+ DPS when that's probably untrue

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue with a new build using a poison-applying skill and the Poison support, then inspect the Calcs tab and Configuration tab. Compare Combined DPS while changing "# of Poison on Enemy" below the displayed Max Poison Stacks value, using the linked Toxic Arrow pastebin as an additional example. Done means the configured poison count changes the reported Combined DPS.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.