PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Pack of Beidat "uptime" not calculated properly
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 5.4k
- Forks
- 2.4k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 26
Description
Check version
- I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
- I've checked for duplicate open and closed issues by using the search function of the issue tracker
What platform are you running Path of Building on?
Windows
How is Path of Building expected to behave?
repeated spells should not count towards empowered spell count.
when using greater spell echo, a spell can repeat 2 times therefore each spell spell should only "exert" every 3 cast
How does Path of Building behave?
the pob empowered spell section counts each cast as an "exertion" and therefor the up time is less. in game i have full uptime of pack of beidat buff in game.
How to reproduce the issue
just add pack of beidat to the skill
go to the calculation section
PoB for PoE1 build code
https://pobb.in/dgYHi6UBhxzP
Screenshots
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in the calculation section with Pack of Beidat enabled, using the linked PoB build to reproduce the reported uptime. Read the handling of repeated spells and Greater Spell Echo, then verify that repeats do not count as separate exertions and that the calculated uptime matches the in-game behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 62/100