PEtab-dev / PEtab-dev/libpetab-python

False positive invalid condition ID.

Open
#366 6 comments 0 reactions 1 assignee View on GitHub

@dilpath is already working on this.

Since Nov 10, 2020.

Dominant language
Python
Stars
18
Forks
9
PR merge metrics
No merged PRs in 30d

Description

Which problem would you like to address? Please describe.
Linting complains about invalid condition IDs. I believe the error is due to the fact that the condition id is numeric only. Ideally the error would be a bit more informative what the actual issue is with the condition ID.

Describe the solution you would like
Change the spec to be more accurate about identifier restrictions or change linting to be more permissive about identifiers.

Describe alternatives you have considered
Don't use numbers in identifiers.

Additional context
Can be checked via check_condition_df(pd.DataFrame({petab.CONDITION_ID: ['0']}).set_index(petab.CONDITION_ID), None).

Not sure how much sense it makes to print line numbers when operating with a DataFrame.

Typehints in check_condition_df are inconsistent with the function signature, i.e., sbml_model is not and optional argument.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.