PEtab-dev / PEtab-dev/libpetab-python

add case in visualization routine: in measurementData file, if same simulationConditionId, but differing preequilibrationId etc.

未关闭
#2 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

visualization
主要语言
Python
星标
18
派生
9
PR 合并指标
30 天内没有已合并 PR

描述

in file 'get_data_to_plot.py', see ll. 92-102
TODO: Here not the case: So, if entries in measurement file: preequCondId, time, observableParams, noiseParams, observableTransf, noiseDistr are not the same, then -> differ these data into different groups!
now: go in simulationConditionId, search group of unique simulationConditionId
e.g. rows 0,6,12,18 share the same simulationCondId, then check if other column entries are the same (now: they are), then take intersection of rows 0,6,12,18 and checked other same columns (-> now: 0,6,12,18) and then go on with code.
if there is at some point a difference in other columns, say e.g. row 12,18 have different noiseParams than rows 0,6 the actual code would take rows 0,6 and forget about rows 12,18

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

调研方向

Start in get_data_to_plot.py around lines 92-102 and inspect how rows sharing a simulationConditionId are grouped. Compare that logic with the listed preequCondId, time, observableParams, noiseParams, observableTransf, and noiseDistr fields. Done means rows with differing values in those fields remain in separate groups and are all processed.

由索引模型根据 Issue 内容生成。

评估

技术栈
python
领域
data-visualization
Issue 类型
缺陷
难度
3/5
预计耗时
1-2 天
活跃度
停滞
描述清晰度
基本清楚
新手友好度
45/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。