PEtab-dev / PEtab-dev/libpetab-python
add case in visualization routine: in measurementData file, if same simulationConditionId, but differing preequilibrationId etc.
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 18
- Forks
- 9
- PR merge metrics
- No merged PRs in 30d
Description
in file 'get_data_to_plot.py', see ll. 92-102
TODO: Here not the case: So, if entries in measurement file: preequCondId, time, observableParams, noiseParams, observableTransf, noiseDistr are not the same, then -> differ these data into different groups!
now: go in simulationConditionId, search group of unique simulationConditionId
e.g. rows 0,6,12,18 share the same simulationCondId, then check if other column entries are the same (now: they are), then take intersection of rows 0,6,12,18 and checked other same columns (-> now: 0,6,12,18) and then go on with code.
if there is at some point a difference in other columns, say e.g. row 12,18 have different noiseParams than rows 0,6 the actual code would take rows 0,6 and forget about rows 12,18
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in get_data_to_plot.py around lines 92-102 and inspect how rows sharing a simulationConditionId are grouped. Compare that logic with the listed preequCondId, time, observableParams, noiseParams, observableTransf, and noiseDistr fields. Done means rows with differing values in those fields remain in separate groups and are all processed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data-visualization
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100