OpenTenBase / OpenTenBase/TXSQL
Bug: fseg_get_pages_info does not release pages during extent iteration
Personne n'a encore pris cette issue.
- Langage dominant
- C++
- Étoiles
- 337
- Forks
- 234
- Métriques de merge des PR
- Aucune PR mergée en 30 j
Description
Bug: fseg_get_pages_info does not release pages during extent iteration
Problem
In fseg_get_pages_info() (storage/innobase/fsp/fsp0fsp.cc), when scanning the FSEG_NOT_FULL and FSEG_FULL extent lists for a segment, the mtr holds latches on every visited page descriptor (xdes) without releasing them until the entire function completes and mtr_commit() is called.
For tables with a large number of extents (large tables or tables with fragmented segments), this can mean holding hundreds or thousands of page latches simultaneously within a single mini-transaction. This causes:
- Excessive buffer pool frame consumption (each latched page pins a buffer pool frame)
- Increased memory pressure and potential OOM
CHECK INDEXon large tables becomes unreliable (may OOM)
Root Cause
The mtr_t memo stack grows unbounded during extent list traversal in fseg_get_pages_info(). Each call to xdes_lst_get_descriptor() and xdes_mtr_get_bit() adds a page latch to the mtr memo, but these latches are only released at mtr_commit() which happens at the very end of the function.
Fix
Add a new function mtr_t::release_all_after_savepoint() that releases all pages held in the mtr memo after a given savepoint. Then in fseg_get_pages_info(), set a savepoint and release pages every 100 iterations, effectively bounding the number of simultaneously held latches.
Changes
-
storage/innobase/include/mtr0mtr.h: Declarerelease_all_after_savepoint(ulint savepoint)method andmtr_release_all_after_savepoint()macro. -
storage/innobase/mtr/mtr0mtr.cc: ImplementRelease_all_after_savepointfunctor andmtr_t::release_all_after_savepoint()method. -
storage/innobase/fsp/fsp0fsp.cc: Infseg_get_pages_info(), add savepoint and release logic every 100 pages during FSEG_NOT_FULL and FSEG_FULL list scans.
Affected Scenarios
CHECK INDEXon large tables —ha_innobase::check_index()→innobase_get_index_status()→fseg_get_pages_info()for both leaf and top segments of each index
Guide de contribution
Aucun guide de contribution indexé pour ce dépôt
Par où commencer
- Lisez l'issue en entier, puis le guide de contribution du projet.
- Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
- Forkez le dépôt et travaillez sur une branche.
- Ouvrez une pull request qui référence le numéro de l'issue.
Piste de recherche
Commencez par lire fseg_get_pages_info() dans storage/innobase/fsp/fsp0fsp.cc, puis examinez les déclarations et l’implémentation de mtr_t dans storage/innobase/include/mtr0mtr.h et storage/innobase/mtr/mtr0mtr.cc. Suivez le chemin CHECK INDEX décrit dans l’issue. Le travail est terminé lorsque les analyses d’extents bornent les verrous de page conservés, tout en préservant les résultats existants des informations de page et le comportement de CHECK INDEX.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Évaluation
- Stack technique
- cpp
- Domaine
- databases
- Type d'issue
- Bug
- Difficulté
- 4/5
- Temps estimé
- 3-5 jours
- Activité
- Calme
- Clarté
- Clairement spécifiée
- Accessibilité débutants
- 57/100