OpenTenBase / OpenTenBase/TXSQL
Bug: fseg_get_pages_info does not release pages during extent iteration
Dieses Issue hat noch niemand übernommen.
- Vorherrschende Sprache
- C++
- Sterne
- 337
- Forks
- 234
- PR-Merge-Kennzahlen
- Keine gemergten PRs in 30 T.
Beschreibung
Bug: fseg_get_pages_info does not release pages during extent iteration
Problem
In fseg_get_pages_info() (storage/innobase/fsp/fsp0fsp.cc), when scanning the FSEG_NOT_FULL and FSEG_FULL extent lists for a segment, the mtr holds latches on every visited page descriptor (xdes) without releasing them until the entire function completes and mtr_commit() is called.
For tables with a large number of extents (large tables or tables with fragmented segments), this can mean holding hundreds or thousands of page latches simultaneously within a single mini-transaction. This causes:
- Excessive buffer pool frame consumption (each latched page pins a buffer pool frame)
- Increased memory pressure and potential OOM
CHECK INDEXon large tables becomes unreliable (may OOM)
Root Cause
The mtr_t memo stack grows unbounded during extent list traversal in fseg_get_pages_info(). Each call to xdes_lst_get_descriptor() and xdes_mtr_get_bit() adds a page latch to the mtr memo, but these latches are only released at mtr_commit() which happens at the very end of the function.
Fix
Add a new function mtr_t::release_all_after_savepoint() that releases all pages held in the mtr memo after a given savepoint. Then in fseg_get_pages_info(), set a savepoint and release pages every 100 iterations, effectively bounding the number of simultaneously held latches.
Changes
-
storage/innobase/include/mtr0mtr.h: Declarerelease_all_after_savepoint(ulint savepoint)method andmtr_release_all_after_savepoint()macro. -
storage/innobase/mtr/mtr0mtr.cc: ImplementRelease_all_after_savepointfunctor andmtr_t::release_all_after_savepoint()method. -
storage/innobase/fsp/fsp0fsp.cc: Infseg_get_pages_info(), add savepoint and release logic every 100 pages during FSEG_NOT_FULL and FSEG_FULL list scans.
Affected Scenarios
CHECK INDEXon large tables —ha_innobase::check_index()→innobase_get_index_status()→fseg_get_pages_info()for both leaf and top segments of each index
Beitragsleitfaden
Für dieses Repository ist kein Beitragsleitfaden indexiert
Erste Schritte
- Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
- Forke das Repository und arbeite in einem Branch.
- Öffne einen Pull Request, der die Issue-Nummer nennt.
Rechercherichtung
Beginne mit dem Lesen von fseg_get_pages_info() in storage/innobase/fsp/fsp0fsp.cc und untersuche anschließend die Deklarationen und Implementierung von mtr_t in storage/innobase/include/mtr0mtr.h und storage/innobase/mtr/mtr0mtr.cc. Verfolge den im Issue beschriebenen CHECK INDEX-Pfad. Die Aufgabe ist abgeschlossen, wenn die Extent-Scans die beibehaltenen Seiten-Latches begrenzen und dabei die bestehenden Ergebnisse der Seiteninformationen sowie das CHECK INDEX-Verhalten erhalten bleiben.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Bewertung
- Tech-Stack
- cpp
- Bereich
- databases
- Issue-Typ
- Bug
- Schwierigkeit
- 4/5
- Geschätzter Aufwand
- 3-5 Tage
- Aktivitätsstatus
- Ruhig
- Klarheit
- Klar beschrieben
- Anfängerfreundlichkeit
- 57/100