OpenTenBase / OpenTenBase/TXSQL

Bug: fseg_get_pages_info does not release pages during extent iteration

Open
#54 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
337
Forks
234
PR merge metrics
No merged PRs in 30d

Description

Bug: fseg_get_pages_info does not release pages during extent iteration

Problem

In fseg_get_pages_info() (storage/innobase/fsp/fsp0fsp.cc), when scanning the FSEG_NOT_FULL and FSEG_FULL extent lists for a segment, the mtr holds latches on every visited page descriptor (xdes) without releasing them until the entire function completes and mtr_commit() is called.

For tables with a large number of extents (large tables or tables with fragmented segments), this can mean holding hundreds or thousands of page latches simultaneously within a single mini-transaction. This causes:

  • Excessive buffer pool frame consumption (each latched page pins a buffer pool frame)
  • Increased memory pressure and potential OOM
  • CHECK INDEX on large tables becomes unreliable (may OOM)

Root Cause

The mtr_t memo stack grows unbounded during extent list traversal in fseg_get_pages_info(). Each call to xdes_lst_get_descriptor() and xdes_mtr_get_bit() adds a page latch to the mtr memo, but these latches are only released at mtr_commit() which happens at the very end of the function.

Fix

Add a new function mtr_t::release_all_after_savepoint() that releases all pages held in the mtr memo after a given savepoint. Then in fseg_get_pages_info(), set a savepoint and release pages every 100 iterations, effectively bounding the number of simultaneously held latches.

Changes
  1. storage/innobase/include/mtr0mtr.h: Declare release_all_after_savepoint(ulint savepoint) method and mtr_release_all_after_savepoint() macro.

  2. storage/innobase/mtr/mtr0mtr.cc: Implement Release_all_after_savepoint functor and mtr_t::release_all_after_savepoint() method.

  3. storage/innobase/fsp/fsp0fsp.cc: In fseg_get_pages_info(), add savepoint and release logic every 100 pages during FSEG_NOT_FULL and FSEG_FULL list scans.

Affected Scenarios

  • CHECK INDEX on large tables — ha_innobase::check_index()innobase_get_index_status()fseg_get_pages_info() for both leaf and top segments of each index

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading fseg_get_pages_info() in storage/innobase/fsp/fsp0fsp.cc, then inspect the mtr_t declarations and implementation in storage/innobase/include/mtr0mtr.h and storage/innobase/mtr/mtr0mtr.cc. Trace the CHECK INDEX path described in the issue. Done means the extent scans bound retained page latches while preserving the existing page information results and CHECK INDEX behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
databases
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Clearly specified
Newbie friendliness
57/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.