NodeBB / NodeBB/nodebb-plugin-write-api

Follow logic is backwards

未关闭
#130 1 条评论 0 个 reaction 已指派 1 人 在 GitHub 查看

@julianlam 已经在做这个了。

开始于 2020年7月14日。

bug
主要语言
JavaScript
星标
136
派生
75
平均合并
1 分钟
30 天内合并 PR
8

描述

For rewriting when this API is merged into core...

Follow's API is of the format /api/v2/users/:uid/follow where :uid is the person to follow, and _uid (or the uid from the non-master key) is the person whose edit list we are editing.

  • This does not follow the convention of assuming that :uid is always referring to the subject.
  • This also does not allow for situations where an admin with a non-master token wants to edit a user's follow list (the API will always only allow them to edit their own list

The API should be: /api/v2/users/:uid/follow/:targetUid where:

  • _uid is the calling user (for permissions checking and so on)
  • uid is the user whose follow list you are editing
  • targetUid is the user you are (un)following

贡献指南

这个仓库没有索引到贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。