NodeBB / NodeBB/nodebb-plugin-write-api

Follow logic is backwards

Abierto
#130 1 comentario 0 reacciones 1 asignado Ver en GitHub

@julianlam ya está trabajando en esto.

Desde el 14/7/2020.

bug
Lenguaje dominante
JavaScript
Estrellas
136
Forks
75
Merge medio
1 min
PR fusionados (30 d)
8

Descripción

For rewriting when this API is merged into core...

Follow's API is of the format /api/v2/users/:uid/follow where :uid is the person to follow, and _uid (or the uid from the non-master key) is the person whose edit list we are editing.

  • This does not follow the convention of assuming that :uid is always referring to the subject.
  • This also does not allow for situations where an admin with a non-master token wants to edit a user's follow list (the API will always only allow them to edit their own list

The API should be: /api/v2/users/:uid/follow/:targetUid where:

  • _uid is the calling user (for permissions checking and so on)
  • uid is the user whose follow list you are editing
  • targetUid is the user you are (un)following

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.