NodeBB / NodeBB/nodebb-plugin-write-api
Follow logic is backwards
Open
@julianlam is already working on this.
Since Jul 14, 2020.
bug
- Dominant language
- JavaScript
- Stars
- 136
- Forks
- 75
- Avg merge
- 1m
- Merged PRs (30d)
- 8
Description
For rewriting when this API is merged into core...
Follow's API is of the format /api/v2/users/:uid/follow where :uid is the person to follow, and _uid (or the uid from the non-master key) is the person whose edit list we are editing.
- This does not follow the convention of assuming that
:uidis always referring to the subject. - This also does not allow for situations where an admin with a non-master token wants to edit a user's follow list (the API will always only allow them to edit their own list
The API should be: /api/v2/users/:uid/follow/:targetUid where:
_uidis the calling user (for permissions checking and so on)uidis the user whose follow list you are editingtargetUidis the user you are (un)following
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.