NativeScript / NativeScript/nativescript-cli
Angular src/app/package.json causing tslint error
@rosen-vladimirov já está trabalhando nisso.
Desde 7/5/2019.
- Linguagem predominante
- JavaScript
- Estrelas
- 1.1k
- Forks
- 204
- Merge médio
- 1d 9h
- PRs com merge (30d)
- 8
Descrição
Environment
tns info
✔ Getting NativeScript components versions information...
✔ Component nativescript has 5.3.4 version and is up to date.
✔ Component tns-core-modules has 5.3.1 version and is up to date.
✔ Component tns-android has 5.3.1 version and is up to date.
✔ Component tns-ios has 5.3.1 version and is up to date.
Describe the bug
Having a package.json in src/app/package.json causes no-implicit-dependencies tslint error
To Reproduce
tns create ns-tab-example- Choose Angular project AND tab navigation temlpate
- Open
src/app/home/home.component.tsin a tslint supported IDE (like VS Code) - See
no-implicit-dependencieson the@angular/coreimport
Expected behavior
no-implicit-dependencies tslint errors should not exist on tns created templates.
Additional context
The problem is there are 2 package.json files in a TNS created Angular project. When tslint goes to find a TS imported module in package.json it 1st finds src/app/package.json with the following contents:
{
"main": "main.js",
"android": {
"v8Flags": "--expose_gc"
}
}
As you can see, the problem is this file has no dependencies defined. Dependencies are defined in the <project root>/package.json file (rightfully so).
So if you import { Component, OnInit } from '@angular/core'; tslint will throw an error like:
Module '@angular/core' is not listed as dependency in package.json (no-implicit-dependencies)
I'm hoping src/app/package.json can be deleted and its contents merged into <project root>/package.json.
tslint errors are a problem for workflows that prohibit commits that fail linting (like CI/CD envs).
Guia de contribuição
Primeiros passos
- Leia a issue inteira e depois o guia de contribuição do projeto.
- Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
- Faça um fork do repositório e trabalhe em uma branch.
- Abra um pull request que referencie o número da issue.
Avaliação
Esta issue ainda não foi avaliada.