NativeScript / NativeScript/nativescript-cli

Angular src/app/package.json causing tslint error

Offen
#4,575 2 Kommentare 2 Reaktionen 1 zugewiesene Person Auf GitHub ansehen

@rosen-vladimirov arbeitet bereits daran.

Seit 07.5.2019.

Vorherrschende Sprache
JavaScript
Sterne
1.1k
Forks
204
Ø Merge
1 T. 9 Std.
Gemergte PRs (30 T.)
8

Beschreibung

Environment

tns info
✔ Getting NativeScript components versions information...
✔ Component nativescript has 5.3.4 version and is up to date.
✔ Component tns-core-modules has 5.3.1 version and is up to date.
✔ Component tns-android has 5.3.1 version and is up to date.
✔ Component tns-ios has 5.3.1 version and is up to date.

Describe the bug

Having a package.json in src/app/package.json causes no-implicit-dependencies tslint error

To Reproduce

  1. tns create ns-tab-example
  2. Choose Angular project AND tab navigation temlpate
  3. Open src/app/home/home.component.ts in a tslint supported IDE (like VS Code)
  4. See no-implicit-dependencies on the @angular/core import

Expected behavior

no-implicit-dependencies tslint errors should not exist on tns created templates.

Additional context

The problem is there are 2 package.json files in a TNS created Angular project. When tslint goes to find a TS imported module in package.json it 1st finds src/app/package.json with the following contents:

{
  "main": "main.js",
  "android": {
    "v8Flags": "--expose_gc"
  }
}

As you can see, the problem is this file has no dependencies defined. Dependencies are defined in the <project root>/package.json file (rightfully so).

So if you import { Component, OnInit } from '@angular/core'; tslint will throw an error like:

Module '@angular/core' is not listed as dependency in package.json (no-implicit-dependencies)

I'm hoping src/app/package.json can be deleted and its contents merged into <project root>/package.json.

tslint errors are a problem for workflows that prohibit commits that fail linting (like CI/CD envs).

Beitragsleitfaden

Beitragsleitfaden öffnen

Erste Schritte

  1. Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
  3. Forke das Repository und arbeite in einem Branch.
  4. Öffne einen Pull Request, der die Issue-Nummer nennt.

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.