NativeScript / NativeScript/nativescript-cli
[android] packaged aar should be by modules appearing after webpack compilation
@KristianDD ci sta già lavorando.
Dal 27/2/2019.
- Lingua principale
- JavaScript
- Stelle
- 1.1k
- Fork
- 204
- Merge medio
- 1g 9h
- PR unite (30g)
- 8
Descrizione
I now use webpack-strip-block in my app to remove code in production.
The idea behind this is to be able to use nativescript-vue-devtools in dev but obviously remove it in production.
So i add this to my webpack
if (!!production) {
config.module.rules.push({
test: /\.tsx?$/,
enforce: 'pre',
exclude: /node_modules/,
use: [
{
loader: 'webpack-strip-block',
options: {
start: 'DEV-START',
end: 'DEV-END'
}
}
]
});
}
and in my app i do something like this:
/* DEV-START */
console.log('only shown in dev', device.model, device.os, device.osVersion, device.manufacturer);
const VueDevtools = require('nativescript-vue-devtools');
Vue.use(VueDevtools);
/* DEV-END */
This works perfectly and the code is removed in prod. So nativescript-dev-tools is not packd in prod.
But remains the issue of the native version of the modules. nativescript-dev-tools depends on nativescript-socket-io which has native lib.
My issue is that nativescript-socket-io native lib will always be packed with my app even if ``nativescript-dev-toolsis stripped and thennativescript-socket-io``` not packaged.
The list of native module to be added by filtering used packages after webpack compilation (not sure how that list is created right now). It should not be based on the package.json
Hope that issue makes sense
Guida per i contributori
Apri la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Valutazione
Questa issue non è ancora stata valutata.