NativeScript / NativeScript/nativescript-cli
[android] packaged aar should be by modules appearing after webpack compilation
@KristianDD y travaille déjà.
Depuis le 27/2/2019.
- Langage dominant
- JavaScript
- Étoiles
- 1.1k
- Forks
- 204
- Merge moyen
- 1 j 9 h
- PR mergées (30 j)
- 8
Description
I now use webpack-strip-block in my app to remove code in production.
The idea behind this is to be able to use nativescript-vue-devtools in dev but obviously remove it in production.
So i add this to my webpack
if (!!production) {
config.module.rules.push({
test: /\.tsx?$/,
enforce: 'pre',
exclude: /node_modules/,
use: [
{
loader: 'webpack-strip-block',
options: {
start: 'DEV-START',
end: 'DEV-END'
}
}
]
});
}
and in my app i do something like this:
/* DEV-START */
console.log('only shown in dev', device.model, device.os, device.osVersion, device.manufacturer);
const VueDevtools = require('nativescript-vue-devtools');
Vue.use(VueDevtools);
/* DEV-END */
This works perfectly and the code is removed in prod. So nativescript-dev-tools is not packd in prod.
But remains the issue of the native version of the modules. nativescript-dev-tools depends on nativescript-socket-io which has native lib.
My issue is that nativescript-socket-io native lib will always be packed with my app even if ``nativescript-dev-toolsis stripped and thennativescript-socket-io``` not packaged.
The list of native module to be added by filtering used packages after webpack compilation (not sure how that list is created right now). It should not be based on the package.json
Hope that issue makes sense
Guide de contribution
Ouvrir le guide de contribution
Par où commencer
- Lisez l'issue en entier, puis le guide de contribution du projet.
- Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
- Forkez le dépôt et travaillez sur une branche.
- Ouvrez une pull request qui référence le numéro de l'issue.
Évaluation
Cette issue n'a pas encore été évaluée.