NativeScript / NativeScript/nativescript-cli

Feature Request: Show warning during iOS build with missing .xcconfig

未關閉
#3,760 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

還沒有人認領這個 Issue。

build feature os: ios
主要語言
JavaScript
星號
1.1k
分支
204
平均合併
1 天 9 小時
30 天內合併 PR
8

描述

Did you verify this is a real problem by searching the NativeScript Forum and the other open issues in this repo?

Yes

Tell us about the problem

Please, ensure your title is less than 63 characters long and starts with a capital
letter.

Which platform(s) does your issue occur on?

iOS

Please provide the following version numbers that your issue occurs with:
  • CLI: 4.2.0-2018-07-12-11970 (next)
    Project is using 4.1.0
Please tell us how to recreate the issue in as much detail as possible.

At some time in previous release, maybe NS 2 or 3x projects provided a build.xcconfig file which specifies:

ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
ASSETCATALOG_COMPILER_LAUNCHIMAGE_NAME = LaunchImage;

for the app icons during a build which works great. However, if this file is deleted (happened on a project today and took hours to figure out why the icons weren't showing when installing the app), then the app icon is not set during a build and no warnings/info is provided.

This could be a potential time saver for others in the future if the file is not found. I don't know all the implications of that file during xcode builds so I won't pretend to 😄 - it would have saved me several hours tracking down the file was deleted months ago from the project repository and that I had to set the icons in xcode on the build settings page after opening the workspace.

貢獻指南

開啟貢獻指南

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

研究方向

先定位 CLI 中的 iOS 建置處理,並搜尋對 build.xcconfig 或 ASSETCATALOG_COMPILER 設定的參照。在缺少該檔案的情況下重現一次建置,接著判斷警告應出現的位置,並確認在檔案存在時建置不會變更且警告會顯示。

由索引模型根據 Issue 內容生成。

評估

技術堆疊
ios, javascript
領域
build-system, cli, mobile
Issue 類型
功能
難度
3/5
預估耗時
1-2 天
活躍度
停滯
描述清晰度
基本清楚
新手友好度
35/100

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。