NativeScript / NativeScript/nativescript-cli
Feature Request: Show warning during iOS build with missing .xcconfig
Dieses Issue hat noch niemand übernommen.
- Vorherrschende Sprache
- JavaScript
- Sterne
- 1.1k
- Forks
- 204
- Ø Merge
- 1 T. 9 Std.
- Gemergte PRs (30 T.)
- 8
Beschreibung
Did you verify this is a real problem by searching the NativeScript Forum and the other open issues in this repo?
Yes
Tell us about the problem
Please, ensure your title is less than 63 characters long and starts with a capital
letter.
Which platform(s) does your issue occur on?
iOS
Please provide the following version numbers that your issue occurs with:
- CLI: 4.2.0-2018-07-12-11970 (next)
Project is using4.1.0
Please tell us how to recreate the issue in as much detail as possible.
At some time in previous release, maybe NS 2 or 3x projects provided a build.xcconfig file which specifies:
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
ASSETCATALOG_COMPILER_LAUNCHIMAGE_NAME = LaunchImage;
for the app icons during a build which works great. However, if this file is deleted (happened on a project today and took hours to figure out why the icons weren't showing when installing the app), then the app icon is not set during a build and no warnings/info is provided.
This could be a potential time saver for others in the future if the file is not found. I don't know all the implications of that file during xcode builds so I won't pretend to 😄 - it would have saved me several hours tracking down the file was deleted months ago from the project repository and that I had to set the icons in xcode on the build settings page after opening the workspace.
Beitragsleitfaden
Erste Schritte
- Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
- Forke das Repository und arbeite in einem Branch.
- Öffne einen Pull Request, der die Issue-Nummer nennt.
Rechercherichtung
Beginne damit, die iOS-Build-Verarbeitung in der CLI zu lokalisieren, und suche nach Verweisen auf build.xcconfig oder die ASSETCATALOG_COMPILER-Einstellungen. Reproduziere einen Build, bei dem die Datei fehlt, bestimme anschließend, wo eine Warnung erscheinen sollte, und überprüfe, dass die Warnung angezeigt wird, ohne Builds zu ändern, bei denen die Datei vorhanden ist.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Bewertung
- Tech-Stack
- ios, javascript
- Bereich
- build-system, cli, mobile
- Issue-Typ
- Feature
- Schwierigkeit
- 3/5
- Geschätzter Aufwand
- 1-2 Tage
- Aktivitätsstatus
- Veraltet
- Klarheit
- Größtenteils klar
- Anfängerfreundlichkeit
- 35/100