NativeScript / NativeScript/nativescript-cli
Livesync hangs when modifying App_Resources in before-prepare hook
Nessuno ha ancora preso questa issue.
- Lingua principale
- JavaScript
- Stelle
- 1.1k
- Fork
- 204
- Merge medio
- 1g 9h
- PR unite (30g)
- 8
Descrizione
Tell us about the problem
When using nativescript-localize with "tns run ios", it tries to sync Localizable.strings without rebuilding the app.
Which platform(s) does your issue occur on?
iOS, haven't tried on Android
Please provide the following version numbers that your issue occurs with:
- CLI: 3.3.1
- Cross-platform modules: 3.3.0
- Runtime(s): 3.3.0
- Plugin(s): nativescript-localize (2.0.5)
- iOS 11 on iPhone X emulator
Please tell us how to recreate the issue in as much detail as possible.
git clone --depth 1 --branch v2.0.5 https://github.com/lfabreges/nativescript-localize.git
cd nativescript-localize
npm install
npm run compile
cd demo
npm install
tns run ios
Then make a change in the app/i18n/en.default.js file, change "Hello World !" to "Hello" for example.
Executing before-prepare hook from /Users/lfabreges/Documents/Developpement/nativescript-localize/demo/hooks/before-prepare/nativescript-localize.js
Preparing project...
Project successfully prepared (iOS)
Successfully transferred en.default.js.
Refreshing application...
Successfully synced application org.nativescript.demo.javascript on device ED5FEB43-DDA2-43FD-B693-4E07FD78CB1C.
Skipping prepare.
Successfully transferred Localizable.strings.
Refreshing application...
Successfully synced application org.nativescript.demo.javascript on device ED5FEB43-DDA2-43FD-B693-4E07FD78CB1C.
More
I think the problem occurs because :
- The plugin modifies Localizable.strings in the App_Resources
- Prepare is done and savePrepareInfo save the .nsprepareinfo file with a modified time greater that Localizable.strings modified time
- The watcher detects that a change has been made to the Localizable.strings and add it to the queue
- Prepared is skipped because no change is detected, appResourcesChanged is not set to true because containsNewerFiles returns false because Localizable.strings has been modified before .nsprepareinfo file is written to disk
- Localizable.strings is synced but without a rebuild and the app hangs, I need to stop tns run, remove the platforms directory and fully rebuild and resinstall the app to make it work again
I tried to hook into the process but did not find a way to fix it, I triggered a build by modifying appResourcesChanged directly into the plugin, it works but Localizable.strings is stilled synced afterwards, so it hangs again.
I'm the author of the plugin, so I can change it if needed. I definitly need some help on it.
Regards.
Guida per i contributori
Apri la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Direzione di ricerca
Riproduci il problema con i comandi dimostrativi di nativescript-localize elencati, quindi esamina hooks/before-prepare/nativescript-localize.js, App_Resources e la gestione di .nsprepareinfo. Traccia l’interazione tra il watcher, la decisione di prepare-skip e la sincronizzazione di Localizable.strings. Il lavoro è completato quando la modifica di app/i18n/en.default.js non blocca più l’app iOS e la ricompilazione richiesta o l’aggiornamento delle risorse viene completato correttamente.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Valutazione
- Stack tecnologico
- ios, javascript
- Ambito
- build-system, cli, mobile-dev
- Tipo di issue
- Bug
- Difficoltà
- 4/5
- Tempo stimato
- 3-5 giorni
- Stato di attività
- Ferma
- Chiarezza
- Abbastanza chiara
- Idoneità per principianti
- 38/100