NativeScript / NativeScript/nativescript-cli
Livesync hangs when modifying App_Resources in before-prepare hook
Nadie ha tomado este issue todavía.
- Lenguaje dominante
- JavaScript
- Estrellas
- 1.1k
- Forks
- 204
- Merge medio
- 1 d 9 h
- PR fusionados (30 d)
- 8
Descripción
Tell us about the problem
When using nativescript-localize with "tns run ios", it tries to sync Localizable.strings without rebuilding the app.
Which platform(s) does your issue occur on?
iOS, haven't tried on Android
Please provide the following version numbers that your issue occurs with:
- CLI: 3.3.1
- Cross-platform modules: 3.3.0
- Runtime(s): 3.3.0
- Plugin(s): nativescript-localize (2.0.5)
- iOS 11 on iPhone X emulator
Please tell us how to recreate the issue in as much detail as possible.
git clone --depth 1 --branch v2.0.5 https://github.com/lfabreges/nativescript-localize.git
cd nativescript-localize
npm install
npm run compile
cd demo
npm install
tns run ios
Then make a change in the app/i18n/en.default.js file, change "Hello World !" to "Hello" for example.
Executing before-prepare hook from /Users/lfabreges/Documents/Developpement/nativescript-localize/demo/hooks/before-prepare/nativescript-localize.js
Preparing project...
Project successfully prepared (iOS)
Successfully transferred en.default.js.
Refreshing application...
Successfully synced application org.nativescript.demo.javascript on device ED5FEB43-DDA2-43FD-B693-4E07FD78CB1C.
Skipping prepare.
Successfully transferred Localizable.strings.
Refreshing application...
Successfully synced application org.nativescript.demo.javascript on device ED5FEB43-DDA2-43FD-B693-4E07FD78CB1C.
More
I think the problem occurs because :
- The plugin modifies Localizable.strings in the App_Resources
- Prepare is done and savePrepareInfo save the .nsprepareinfo file with a modified time greater that Localizable.strings modified time
- The watcher detects that a change has been made to the Localizable.strings and add it to the queue
- Prepared is skipped because no change is detected, appResourcesChanged is not set to true because containsNewerFiles returns false because Localizable.strings has been modified before .nsprepareinfo file is written to disk
- Localizable.strings is synced but without a rebuild and the app hangs, I need to stop tns run, remove the platforms directory and fully rebuild and resinstall the app to make it work again
I tried to hook into the process but did not find a way to fix it, I triggered a build by modifying appResourcesChanged directly into the plugin, it works but Localizable.strings is stilled synced afterwards, so it hangs again.
I'm the author of the plugin, so I can change it if needed. I definitly need some help on it.
Regards.
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Línea de trabajo
Reproduce el problema con los comandos de demostración de nativescript-localize indicados y, a continuación, inspecciona hooks/before-prepare/nativescript-localize.js, App_Resources y el manejo de .nsprepareinfo. Traza cómo interactúan el watcher, la decisión de prepare-skip y la sincronización de Localizable.strings. Se considera terminado cuando cambiar app/i18n/en.default.js ya no bloquea la aplicación iOS y la recompilación requerida o la actualización de recursos se completa correctamente.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- ios, javascript
- Área
- build-system, cli, mobile-dev
- Tipo de issue
- Error
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Estado de actividad
- Estancado
- Claridad
- Bastante claro
- Aptitud para principiantes
- 38/100