NativeScript / NativeScript/android

Publish debug symbols for nativescript-optimized.aar, not only for nativescript-regular.aar

Aperta
#1,982 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Lingua principale
C++
Stelle
563
Fork
144
Merge medio
10h 46m
PR unite (30g)
14

Descrizione

Is your feature request related to a problem? Please describe.
I'm trying to get native crashes of our app symbolicated. Sentry and Play Console both show only raw offsets inside libNativeScript.so. Every release here ships a debug-symbols.zip, which looked like exactly what I needed, but unless I'm misreading things it doesn't match release builds: the gradle template picks the optimized runtime for release builds, while the published symbols are built from the regular flavor. Since Sentry and Play match symbols strictly by BuildID, the published symbols can only ever apply to debug builds, and production crashes stay unsymbolicated.

Describe the solution you'd like
Publish the unstripped optimized build as well (debug-symbols-optimized.zip or similar, or both flavors in one zip), the same way it's already done for the regular flavor. That would make production native crashes debuggable without any build changes on the app side. It might also be worth mentioning in the release notes which flavor the existing zip corresponds to.

Describe alternatives you've considered

  • Setting "android": { "useV8Symbols": true } so that release builds ship the regular flavor, which the published symbols do match. That works, but it means giving up -O3 and section gc on the runtime glue and shipping the inspector code in production, just to get matching symbols.
  • Building the runtime from source with symbols. Possible, but a lot of infrastructure for something the release pipeline here already produces for the other flavor.
  • Living with unsymbolicated native frames.

Additional context
BuildIDs checked with v9.0.4 on arm64-v8a:

regular (npm AAR):                  BuildID[sha1]=d7c0ab67…, stripped
optimized (npm AAR):                BuildID[sha1]=68bb8632…, stripped
optimized-with-inspector (npm AAR): BuildID[sha1]=d7c0ab67…, stripped
debug-symbols.zip:                  BuildID[sha1]=d7c0ab67…, with debug_info, not stripped

It took me a while with file and readelf to figure out why nothing matched, so hopefully this saves the next person the detour. And if I'm missing something and there is already a way to get matching symbols for the optimized runtime, happy to be corrected.

Guida per i contributori

Apri la guida per i contributori

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Direzione di ricerca

Inizia tracciando il packaging della release che crea debug-symbols.zip e l’AAR ottimizzato, quindi confronta i BuildIDs degli artefatti normale e ottimizzato. Il lavoro è completato quando gli output della release includono simboli di debug corrispondenti al runtime ottimizzato e il nome dell’artefatto o le release notes identificano il flavor.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
android, cpp
Ambito
build-system, mobile, release
Tipo di issue
Funzionalità
Difficoltà
4/5
Tempo stimato
3-5 giorni
Stato di attività
Tranquilla
Chiarezza
Abbastanza chiara
Idoneità per principianti
52/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.