NVIDIA / NVIDIA/Personal-AI-Router
[Bug]: manual nodes are persisted only by the desktop app, so a headless nvpair-tui node loses them on every restart
まだ誰も着手していません。
- 主要言語
- Go
- スター
- 1.4k
- フォーク
- 250
- 平均マージ
- 23時間 27分
- マージ済み PR(30日)
- 1
説明
PAIR version or commit
Debian package nvpair 0.1.1-463 (amd64). nvpair-ui-broker --version reports 0.40.2.
Affected component
Discovery or pairing
Environment
OS: Ubuntu 26.04 LTS, x86_64
Front end: nvpair-tui only (started by a `systemd --user` unit inside tmux, linger enabled).
The Electron desktop app is not installed on these nodes.
GPU / driver: consumer NVIDIA GPUs, driver 595.91.07
Engine: Ollama 0.33.3, adopted by PAIR as the node engine
Cluster size: 5 nodes joined to one cluster, split across two routed subnets
Steps to reproduce
- On a node whose only front end is
nvpair-tui, open the Manual tab, pressa, enter a peer address, press Enter. - Confirm the entry is listed as
OLLAMA yes / NODE yes, and that the peer appears in Proxies -> Ollama upstreams. - Restart the front end and its broker:
systemctl --user restart nvpair-tui. - Open the Manual tab again.
Expected behavior
The manual node list survives a restart on any supported front end.
This matters because on a cluster split across routed subnets, manual nodes are the only way to
pair peers at all (mDNS does not cross subnets, and #1 additionally prevents reflectors from
relaying the records). Losing the list on every restart makes such a cluster impractical to
operate without the desktop app.
Actual behavior
After the restart the Manual tab shows No manual nodes. and the peer is gone from
Ollama upstreams. Nothing was written to disk: configs/manual-nodes.json never appears
in the per-user data dir, and the configs/ directory is not created.
Reading the source, the durable list appears to be implemented only in the Electron app:
desktop/src/electron/service-bridge/manual-nodes-store.tsreads and writes
<userData>/configs/manual-nodes.jsonwith entries{ id, address, name }.desktop/src/electron/service-bridge/modular-supervisor.tsnotes that
"PAIR UI owns the durable list (manual-nodes.json) and replays it once".services/nvpair-ui-broker/manualnodes.goperforms no file I/O, and
services/nvpair-tui/ui/manualnodes.goneither reads nor writes that file.services/nvpair-manual-nodesis stateless by design — its README documents
node/add,node/remove,nodes/listand no state or config-path flag.
So the replay is desktop-only, even though services/nvpair-node-settings/README.md already
describes manual-nodes.json as living in the per-user data dir, "same directory as
settings.json" — which reads as if the file is meant to be a per-node artifact rather than a
private detail of the desktop app.
Suggested fix
Move ownership of the durable list, and the one-shot replay after ready, into
nvpair-ui-broker. The broker already supervises nvpair-manual-nodes over JSON-RPC and
already has node/add available, so every front end — desktop, TUI, and any future
service mode (cf. #49, #32) — would inherit persistence without its own copy of the logic.
Sanitized logs
Manual tab, immediately after adding the entry:
ID ADDRESS OLLAMA NODE
manual:peer-a.… peer-a.example.internal yes yes
Per-user data dir at the same moment (no configs/ directory is created):
$ ls "$HOME/.config/Nvidia Corporation/Personal AI Router/configs/"
ls: cannot access '.../configs/': No such file or directory
After systemctl --user restart nvpair-tui:
No manual nodes. Press a to add one by address.
a add node • r remove node • tab next • shift+tab prev • ? help • q quit
$ ls "$HOME/.config/Nvidia Corporation/Personal AI Router/configs/"
ls: cannot access '.../configs/': No such file or directory
Related
- #1 — mDNS answers sent from an ephemeral source port, so reflectors never relay node records
across subnets. Together with this issue, a routed multi-subnet cluster cannot be kept paired
from a headless node. - #49 — Build a service version on Linux.
- #32 — Run a services-only PAIR node as a container or Kubernetes pod.
Confirmations
- I searched existing issues for duplicates.
- This is not a security vulnerability.
- I agree to follow the Code of Conduct.
コントリビューションガイド
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
調査の方向性
services/nvpair-ui-broker/manualnodes.go と services/nvpair-tui/ui/manualnodes.go から始め、desktop/src/electron/service-bridge/manual-nodes-store.ts および supervisor の replay 動作と比較してください。文書化されている systemctl コマンドで再起動を再現し、ユーザーごとのデータパスについて node-settings README を確認してください。TUI、desktop、service-mode の front end で、ready 後に manual nodes が永続化され、replay されれば完了です。
索引モデルが issue の本文から書いたものです。
評価
- 技術スタック
- go, typescript
- 領域
- backend, desktop
- issue の種類
- バグ
- 難易度
- 4/5
- 見積もり時間
- 3〜5日
- 活発さ
- 活発
- 明瞭さ
- 明確に書かれている
- 初心者へのやさしさ
- 65/100