MetaMask / MetaMask/github-tools

`changelog-check` does not exclude `test/` and `tests/`

Open
#158 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
12
Forks
7
Avg merge
1d 1h
Merged PRs (30d)
10

Description

The `no-changelog` label had to be added to a [PR](https://github.com/MetaMask/core/pull/7001#issuecomment-3492920205) recently because it seems that while the `changelog-check` workflow excludes changes to `.test.ts` files, it does not exclude changes to `test/` and `tests/`. We should do that.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating the changelog-check workflow and inspect how it currently excludes .test.ts files. Update the workflow so changes under test/ and tests/ receive the same exclusion, then run the workflow's available checks or validate it against a pull request containing only test changes.

Written by the indexing model from the issue text.

Assessment

Tech stack
github-actions, typescript
Domain
ci-cd
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.