MetaMask / MetaMask/core

Rename Controller metadata `anonymous` property

Open
#643 1 comment 1 reaction 0 assignees View on GitHub
team-assets team-wallet-framework wf-controller-tech-debt
Dominant language
TypeScript
Stars
413
Forks
308
Avg merge
1d 4h
Merged PRs (30d)
253

Description

The `anonymous` property of the Base Controller v2 metadata state is meant to indicate whether the state is already anonymized or not, or if it's a function, it's meant as an anonymizing function.

This property is often misinterpreted to mean the _opposite_ of what it's intended to mean though. People have thought `anonymous: true` means that the data _should be anonymized_, rather than indicating that it has already been anonymized.

To clarify the meaning, this should be renamed to something easier to understand. Maybe `anonymized`?

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating the Base Controller v2 metadata definition and every use of the `anonymous` property across the TypeScript monorepo. Trace how the boolean or function is interpreted before renaming the references; done means the metadata consistently uses the clearer name without changing its existing anonymization semantics.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
api
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.