Old "Lua" output channel remains active after restarting server
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 215
- Forks
- 62
- PR merge metrics
- No merged PRs in 30d
Description
Which OS are you using?
MacOS
Expected Behaviour
When restarting the language server, I expect the output channel to be either
- cleared and reused by the new server instance
- or deleted and a new one used to replace it
Actual Behaviour
The old channel is never destroyed, leaving multiple channels with the same name which can be confusing if you're looking for new channel output.
Reproduction steps
- Open a Lua file
- Run the
Lua: Restart Language Servercommand (many times makes it more obvious) - Open the output channel selector dropdown (
Output: Show Output Channels...)
Additional Notes
I think this is probably pretty simple to fix, just by either clear()ing and reusing or destroy()ing the OutputChannel used for logging.
Log
file_Users_ianchamberlain_Documents_Development_moon-rs-ls.log
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the handler for the Lua: Restart Language Server command and trace how its VS Code OutputChannel is created and retained. Reproduce the restart repeatedly, then verify that Output: Show Output Channels... contains only the current Lua channel and that new server output appears there.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript, vscode
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100