LuaLS / LuaLS/vscode-lua

Old "Lua" output channel remains active after restarting server

Open
#164 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
215
Forks
62
PR merge metrics
No merged PRs in 30d

Description

### Which OS are you using?

MacOS

### Expected Behaviour

When restarting the language server, I expect the output channel to be either
- cleared and reused by the new server instance
- or deleted and a new one used to replace it

### Actual Behaviour

The old channel is never destroyed, leaving multiple channels with the same name which can be confusing if you're looking for new channel output.

### Reproduction steps

1. Open a Lua file
2. Run the `Lua: Restart Language Server` command (many times makes it more obvious)
3. Open the output channel selector dropdown (`Output: Show Output Channels...`)

Image

### Additional Notes

I think this is probably pretty simple to fix, just by either `clear()`ing and reusing or `destroy()`ing the [OutputChannel](https://code.visualstudio.com/api/references/vscode-api#OutputChannel) used for logging.

### Log

[file_Users_ianchamberlain_Documents_Development_moon-rs-ls.log](https://github.com/user-attachments/files/19100943/file_Users_ianchamberlain_Documents_Development_moon-rs-ls.log)

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with the handler for the `Lua: Restart Language Server` command and trace how its VS Code `OutputChannel` is created and retained. Reproduce the restart repeatedly, then verify that `Output: Show Output Channels...` contains only the current Lua channel and that new server output appears there.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript, vscode
Domain
tooling
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.