LuaLS / LuaLS/lua-language-server
noisy `-32801` ("Content Modified") errors
Nadie ha tomado este issue todavía.
- Lenguaje dominante
- Lua
- Estrellas
- 4.4k
- Forks
- 442
- Métricas de merge de PR
- Sin PR fusionados en 30 d
Descripción
How are you using the lua-language-server?
NeoVim
Which OS are you using?
MacOS
What is the issue affecting?
Other
Expected Behaviour
In the request-completion path, when the server has computed a result against document version V, return that result regardless of whether didChange for V+1 (or later) has since arrived. Only return -32801 if the document
modification was genuinely external / out-of-band — which is rare in normal usage and not what didChange represents.
If pre-empting in-flight requests on didChange is desired as an optimization, the spec-compliant signal is for the client to send $/cancelRequest. The server should not unilaterally short-circuit valid in-flight work with -32801.
Per the spec, the client is supposed to handle staleness via cancellation. With lua-language-server pre-empting that decision and erroring instead:
- Clients that handle
-32801strictly as an error end up logging spurious errors (cf. neovim/neovim#40208). - Clients that could have used the older-version result (perfectly valid per the spec — "even computed on an older state might still be useful") never get the chance.
- Clients that wanted to cancel can no longer rely on
$/cancelRequestsemantics because the server has already aborted on its own initiative.
Actual Behaviour
Sending a fast sequence of didChanges while semantic-tokens requests are in flight causes the server to error every in-flight request with:
{ "code": -32801, "message": "Content modified." }
even though the modification was delivered through normal didChange notifications, not "outside normal conditions."
Reproduction steps
- Open a Lua file in any LSP-capable editor that requests
semanticTokens/full(e.g. Neovim 0.12+). - Start typing across multiple lines, fast enough that successive
didChangenotifications outpace the server's processing. - Observe: every in-flight semantic-tokens request comes back with
-32801 Content modified.instead of a (possibly stale) result.
Additional Notes
lua-language-server returns LSP error -32801 ("Content Modified") in response to textDocument/semanticTokens/full (and likely other requests) whenever a textDocument/didChange notification arrives before the response is sent.
This contradicts the LSP specification, which explicitly forbids using -32801 for content changes detected in unprocessed messages — i.e. for the exact case currently being signaled.
What the spec says:
LSP §responseError.code (specifically the ContentModified = -32801 entry):
The server detected that the content of a document got modified outside normal conditions. A server should NOT send this error code if it detects a content change in its unprocessed messages. The result even computed on an older
state might still be useful for the client.If a client decides that a result is not of any use anymore the client should cancel the request.
So the intended semantics are:
-32801is for "out-of-band" content modification (e.g., the file on disk changed in a way the server can't reconcile with its in-flight state).
Log File
No response
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Línea de trabajo
Comienza trazando la ruta de la solicitud textDocument/semanticTokens/full y cómo las notificaciones textDocument/didChange afectan a las solicitudes en curso. Compara ese comportamiento con la especificación de LSP responseError.code; el trabajo estará terminado cuando los cambios de documento normales en cola ya no produzcan -32801, mientras que las modificaciones realmente externas todavía puedan hacerlo.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- lua, neovim
- Área
- devtools
- Tipo de issue
- Error
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Estado de actividad
- Tranquilo
- Claridad
- Bastante claro
- Aptitud para principiantes
- 48/100