LuaLS / LuaLS/lua-language-server
Issue when using tables/class with generics?
還沒有人認領這個 Issue。
- 主要語言
- Lua
- 星號
- 4.4k
- 分支
- 442
- PR 合併指標
- 30 天內沒有已合併 PR
描述
How are you using the lua-language-server?
Visual Studio Code Extension (sumneko.lua)
Which OS are you using?
Windows
What is the issue affecting?
Type Checking
Expected Behaviour
In the following code:
---@class TestClass
---@field test string
---@field test2 string
---@param test TestClass
local function test_function(test)
for k, v in pairs(test) do end
---@type {test: string, test2: string}
local test_table
for k, v in pairs(test_table) do end
---@type {test: string, test2: string}
local test_table2 = {
test = "test",
test2 = "test2",
}
for k, v in pairs(test_table2) do end
end
I would hope that the inferred type of k and v would work the same in each instance where k is inferred to be a string and v is inferred to be a string.
Actual Behaviour
In the following code:
---@class TestClass
---@field test string
---@field test2 string
---@param test TestClass
local function test_function(test)
for k, v in pairs(test) do end
---@type {test: string, test2: string}
local test_table
for k, v in pairs(test_table) do end
---@type {test: string, test2: string}
local test_table2 = {
test = "test",
test2 = "test2",
}
for k, v in pairs(test_table2) do end
end
the k and in line: for k, v in pairs(test) do end and the k in line for k, v in pairs(test_table) do end get the error can not infer type and are typed as unknown.
I assume there is some issue here with generics as the pairs definition uses them heavily
---@generic T: table, K, V
---@param t T
---@return fun(table: table<K, V>, index?: K):K, V
---@return T
but this is only a guess.
Reproduction steps
- Copy this code:
---@class TestClass
---@field test string
---@field test2 string
---@param test TestClass
local function test_function(test)
for k, v in pairs(test) do end
---@type {test: string, test2: string}
local test_table
for k, v in pairs(test_table) do end
---@type {test: string, test2: string}
local test_table2 = {
test = "test",
test2 = "test2",
}
for k, v in pairs(test_table2) do end
end
- See errors
Additional Notes
No response
Log File
No response
貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
研究方向
先在 Visual Studio Code 擴充功能中重現提供的程式碼片段,然後檢查 pairs 的定義及其泛型回傳型別。當在 TestClass、未初始化表格和已初始化表格的情況下,k 和 v 都能被推斷為 string,且不會出現 can not infer type 錯誤時,修正就完成了。
由索引模型根據 Issue 內容生成。
評估
- 技術堆疊
- lua
- 領域
- devtools
- Issue 類型
- 缺陷
- 難度
- 4/5
- 預估耗時
- 3-5 天
- 活躍度
- 停滯
- 描述清晰度
- 基本清楚
- 新手友好度
- 42/100