LuaLS / LuaLS/lua-language-server
Issue when using tables/class with generics?
还没有人认领这个 Issue。
- 主要语言
- Lua
- 星标
- 4.4k
- 派生
- 442
- PR 合并指标
- 30 天内没有已合并 PR
描述
### How are you using the lua-language-server?
Visual Studio Code Extension (sumneko.lua)
### Which OS are you using?
Windows
### What is the issue affecting?
Type Checking
### Expected Behaviour
In the following code:
```
---@class TestClass
---@field test string
---@field test2 string
---@param test TestClass
local function test_function(test)
for k, v in pairs(test) do end
---@type {test: string, test2: string}
local test_table
for k, v in pairs(test_table) do end
---@type {test: string, test2: string}
local test_table2 = {
test = "test",
test2 = "test2",
}
for k, v in pairs(test_table2) do end
end
```
I would hope that the inferred type of k and v would work the same in each instance where k is inferred to be a string and v is inferred to be a string.
### Actual Behaviour
In the following code:
```
---@class TestClass
---@field test string
---@field test2 string
---@param test TestClass
local function test_function(test)
for k, v in pairs(test) do end
---@type {test: string, test2: string}
local test_table
for k, v in pairs(test_table) do end
---@type {test: string, test2: string}
local test_table2 = {
test = "test",
test2 = "test2",
}
for k, v in pairs(test_table2) do end
end
```
the k and in line: `for k, v in pairs(test) do end` and the k in line` for k, v in pairs(test_table) do end` get the error `can not infer type` and are typed as `unknown`.
I assume there is some issue here with generics as the pairs definition uses them heavily
```
---@generic T: table, K, V
---@param t T
---@return fun(table: table, index?: K):K, V
---@return T
```
but this is only a guess.
### Reproduction steps
1. Copy this code:
```
---@class TestClass
---@field test string
---@field test2 string
---@param test TestClass
local function test_function(test)
for k, v in pairs(test) do end
---@type {test: string, test2: string}
local test_table
for k, v in pairs(test_table) do end
---@type {test: string, test2: string}
local test_table2 = {
test = "test",
test2 = "test2",
}
for k, v in pairs(test_table2) do end
end
```
2. See errors
### Additional Notes
_No response_
### Log File
_No response_
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
调研方向
首先在 Visual Studio Code 扩展中复现提供的代码片段,然后检查 `pairs` 的定义及其泛型返回类型。当在 `TestClass`、未初始化表和已初始化表这几种情况下,`k` 和 `v` 都能被推断为 string,且不会出现 `can not infer type` 错误时,修复就完成了。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- lua
- 领域
- devtools
- Issue 类型
- 缺陷
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 活跃度
- 停滞
- 描述清晰度
- 基本清楚
- 新手友好度
- 42/100