LuaLS / LuaLS/lua-language-server

Square brackets ignore class field check

Open
#1,964 1 comment 0 reactions 0 assignees View on GitHub
as designed
Dominant language
Lua
Stars
4.4k
Forks
442
PR merge metrics
No merged PRs in 30d

Description

### How are you using the lua-language-server?

Visual Studio Code Extension (sumneko.lua)

### Which OS are you using?

Linux

### What is the issue affecting?

Type Checking, Diagnostics/Syntax Checking

### Expected Behaviour

Classes check fields correctness regardless of access form class["bad"] and class.bad should both cause error

### Actual Behaviour

![image](https://user-images.githubusercontent.com/49253162/222428775-4172d850-5a73-4562-b39d-c8d68a8fb17b.png)

### Reproduction steps

Create class with fields. Access to non-existing field using `["field-name"]`.

### Additional Notes

_No response_

### Log File

_No response_

Contributor guide

Open the contributing guide

Research direction

Reproduce the diagnostic in the Lua language server using a class field access written as class["field-name"], then compare it with class.field. Trace the type-checking and diagnostics path responsible for class field lookup; done means both access forms report nonexistent fields consistently.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
devtools
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.