Kernix13 / Kernix13/codeCompare

Set a max of 3 compare languages

Đang mở
#7 0 bình luận 0 reaction 1 người được giao Được @Kernix13 nhận Xem trên GitHub
ui
Ngôn ngữ chính
JavaScript
Star
1
Fork
1
Chỉ số merge pull request
Không có pull request nào được merge trong 30 ngày

Mô tả

Have a primary + 3 languages to compare with the user's primary is too much UNLESS the user has a large and extra wide monitor. But if the user does have that capability, then that should be the max - 1 primary + 3 secondary = 4 grid columns. At that point all remaining secondary checkboxes should be disabled. However, once a user unchecks 1 or more secondary languages, then remove the disabled attribute.

It would also be nice to read the user's screen width and apply logic to the max number of secondary languages.

In reality, allowing only 1 secondary language makes the most sense. That is what I am going to do for the details screen which will have `

` blocks with more than a few lines of code. But having 2 secondary languages on the compare page makes sense if the user knows a second language fairly well - then they can compare their primary language with their second strongest language to the 3rd language they are looking to learn. 

However, it also makes sense to just have 1 secondary language on the compare page as well. The problem with that though, is there could be a huge difference between their primary and secondary given the environments they run in - front-end-web vs. back-end web vs mobile app vs computer software, ...

Hướng dẫn đóng góp

Mở hướng dẫn đóng góp

Đánh giá

Issue này chưa được đánh giá.

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.