PyCall build silenty fails to use virtualenv if ENV["PYTHON"] set incorrectly.
- Langage dominant
- Julia
- Étoiles
- 1.5k
- Forks
- 186
- Métriques de merge des PR
- Aucune PR mergée en 30 j
Description
Hi there, I think it would be good to have a warning if `ENV["PYTHON"]` does not point to a python binary. I was setting it to the location of the virtual environment, without the `bin/python` appended to the end. This caused `PyCall` to build for the `Conda.jl` setup, without reporting why the virtual environment I wanted to use wasn't being picked up. It took me more time than I'm comfortable admitting to realize the problem 😬 .
This sounds pretty simple to fix. If it's agreeable, I'd be happy to write a small PR to add a warning when `ENV["PYTHON"]` (or `ENV["PYCALL_JL_RUNTIME_PYTHON"]`) do not point to a valid binary.
Guide de contribution
Aucun guide de contribution indexé pour ce dépôt
Piste de recherche
Start by tracing how PyCall handles ENV["PYTHON"] and ENV["PYCALL_JL_RUNTIME_PYTHON"] during its build configuration. Verify the behavior for values that name a virtual-environment directory rather than a Python binary, and consider the work complete when that case produces a clear warning instead of silently selecting another setup.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Évaluation
- Stack technique
- julia, python
- Domaine
- tooling
- Type d'issue
- Bug
- Difficulté
- 2/5
- Temps estimé
- 1-3 heures
- Activité
- À l'abandon
- Clarté
- Plutôt claire
- Accessibilité débutants
- 45/100