PyCall build silenty fails to use virtualenv if ENV["PYTHON"] set incorrectly.
- Vorherrschende Sprache
- Julia
- Sterne
- 1.5k
- Forks
- 186
- PR-Merge-Kennzahlen
- Keine gemergten PRs in 30 T.
Beschreibung
Hi there, I think it would be good to have a warning if `ENV["PYTHON"]` does not point to a python binary. I was setting it to the location of the virtual environment, without the `bin/python` appended to the end. This caused `PyCall` to build for the `Conda.jl` setup, without reporting why the virtual environment I wanted to use wasn't being picked up. It took me more time than I'm comfortable admitting to realize the problem 😬 .
This sounds pretty simple to fix. If it's agreeable, I'd be happy to write a small PR to add a warning when `ENV["PYTHON"]` (or `ENV["PYCALL_JL_RUNTIME_PYTHON"]`) do not point to a valid binary.
Beitragsleitfaden
Für dieses Repository ist kein Beitragsleitfaden indexiert
Rechercherichtung
Start by tracing how PyCall handles ENV["PYTHON"] and ENV["PYCALL_JL_RUNTIME_PYTHON"] during its build configuration. Verify the behavior for values that name a virtual-environment directory rather than a Python binary, and consider the work complete when that case produces a clear warning instead of silently selecting another setup.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Bewertung
- Tech-Stack
- julia, python
- Bereich
- tooling
- Issue-Typ
- Bug
- Schwierigkeit
- 2/5
- Geschätzter Aufwand
- 1-3 Stunden
- Aktivitätsstatus
- Veraltet
- Klarheit
- Größtenteils klar
- Anfängerfreundlichkeit
- 45/100