ISISComputingGroup / ISISComputingGroup/streaming-data-types

run start/stops: fields that are required are not marked as required

Ouverte
#11 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
Langage dominant
Rust
Étoiles
0
Forks
0
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

https://github.com/ISISComputingGroup/streaming-data-types/blob/master/schemas/pl72_run_start.fbs and https://github.com/ISISComputingGroup/streaming-data-types/blob/master/schemas/6s4t_run_stop.fbs don't use the `(required)` suffix after typing their fields, on required fields.

See [ev44](https://github.com/ISISComputingGroup/streaming-data-types/blob/master/schemas/ev44_events.fbs#L6) which _does_ use this syntax correctly

technically this is breaking but i don't know if we really want to change the file id and create a new schema or not - probably not.

Guide de contribution

Aucun guide de contribution indexé pour ce dépôt

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.