ISISComputingGroup / ISISComputingGroup/streaming-data-types

run start/stops: fields that are required are not marked as required

Open Beginner friendly
#11 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
0
Forks
0
PR merge metrics
No merged PRs in 30d

Description

https://github.com/ISISComputingGroup/streaming-data-types/blob/master/schemas/pl72_run_start.fbs and https://github.com/ISISComputingGroup/streaming-data-types/blob/master/schemas/6s4t_run_stop.fbs don't use the `(required)` suffix after typing their fields, on required fields.

See [ev44](https://github.com/ISISComputingGroup/streaming-data-types/blob/master/schemas/ev44_events.fbs#L6) which _does_ use this syntax correctly

technically this is breaking but i don't know if we really want to change the file id and create a new schema or not - probably not.

Contributor guide

No contributing guide indexed for this repository

Research direction

Compare the field declarations in schemas/pl72_run_start.fbs and schemas/6s4t_run_stop.fbs with the required-field syntax shown in schemas/ev44_events.fbs. Check the schema and file-ID compatibility implications before making any changes; done means the required fields are represented consistently and the versioning decision is documented or reflected in the change.

Written by the indexing model from the issue text.

Assessment

Domain
data
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.