ISISComputingGroup / ISISComputingGroup/DataStreaming

`kafka_dae_control`: periods: attempt to prevent invalid configurations

未關閉
#103 5 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
good first issue
主要語言
沒有語言資料
星號
0
分支
0
PR 合併指標
30 天內沒有已合併 PR

描述

In `COMPUTER` control mode:
- If I try to set `PERIODS:SP` to larger than `NUMPERIODS:MAX`, I should get an error.
- If I'm in period `N` and I try to change `NUMPERIODS:MAX` to less than `N`, put back to period 0 (user period 1)?
- I probably shouldn't be allowed to set `NUMPERIODS:MAX` to zero
- If I was previously in period N and this was done by `EXTERNAL` or `LOOKUP` control mode, then when I change to `COMPUTER` control mode this should be verified against `NUMPERIODS:MAX` and set back to something valid if `N` is larger than `NUMPERIODS:MAX`.
- As per discussion below, `NOT_USED` is not a real control mode (it was meant to say that this bit-pattern does not correspond to anything in the hardware). Remove references to `NOT_USED` in our code.

貢獻指南

這個儲存庫沒有索引到貢獻指南

研究方向

Start at the `kafka_dae_control` entry point named in the issue and trace how control modes, `PERIODS:SP`, and `NUMPERIODS:MAX` are handled. Verify the COMPUTER-mode bounds, period reset behavior, validation when switching from EXTERNAL or LOOKUP, and removal of NOT_USED references; add or run the relevant tests to confirm each case.

由索引模型根據 Issue 內容生成。

評估

技術堆疊
kafka
領域
embedded-iot
Issue 類型
缺陷
難度
4/5
預估耗時
3-5 天
活躍度
冷清
描述清晰度
需要釐清
新手友好度
45/100

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。